Skip to content

Conversation

@mediremi
Copy link
Member

@mediremi mediremi commented Sep 11, 2024

With the move from the ninja-based build system to rewatch, it makes sense to replace NINJA_ANSI_FORCED with FORCE_COLOR to force colorized output.

This PR also fixes rescript_bsb.js not having a way to force colorized output.

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good to me.

@zth Ok to go with FORCE_COLOR?

@zth
Copy link
Member

zth commented Sep 12, 2024

@cknitt sure, sounds great!

@cknitt
Copy link
Member

cknitt commented Sep 12, 2024

Great! Could you add a CHANGELOG entry @mediremi?

@mediremi mediremi marked this pull request as ready for review September 12, 2024 11:32
@mediremi
Copy link
Member Author

@cknitt changelog entry added 👍

@cknitt cknitt merged commit 8120131 into rescript-lang:master Sep 12, 2024
20 checks passed
@mediremi mediremi deleted the force-color-env branch May 24, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants